YahooArchive / end-to-end

Use OpenPGP-based encryption in Yahoo mail.
http://yahoo.tumblr.com/post/113708033335/user-focused-security-end-to-end-encryption
Apache License 2.0
223 stars 40 forks source link

Lookup API to keyserver v2 #62

Closed adon-at-work closed 8 years ago

adon-at-work commented 8 years ago

p.s. will rebase before this gets merged.

@andres-erbsen , @daniel-ziegler , @diracdeltas. please see if you can give it a review. thanks

andres-erbsen commented 8 years ago

I checked that

I think @daniel-ziegler is more qualified to check https://github.com/yahoo/end-to-end/blob/feature/treeproof/src/javascript/crypto/e2e/coname/lookup_verify.js#L378 and onwards; I will check in with him and do it myself in case he is not available.

andres-erbsen commented 8 years ago

The realm name check we discussed over email is now present in the Go code: https://github.com/yahoo/coname/pull/34/files#diff-a53cc11e5be81686d4eee400a9d85c86R102. Please incorporate it to the JS version as well.

adon-at-work commented 8 years ago

Thanks @andres-erbsen. I'll let you or @daniel-ziegler to check the rest of it (line 378 and onwards). I prefer to leave this PR as is, and will incorporate the realm name check in a separate PR, which I expect to also have all protobuf and the whole ajax request ready. Gotta rewrite some of the code due to the 32 vs 64 bit issue due to the JS protobuf.

adon-at-work commented 8 years ago

merging for now. we'll need another review on the complete lookup client. thanks @andres-erbsen

adon-at-work commented 8 years ago

reversed the merge from master. will merge again with the changes rebased. see https://github.com/yahoo/end-to-end/issues/65 for details