YahooArchive / fluxible-router

MOVED TO FLUXIBLE REPO
104 stars 26 forks source link

Moving to Immutable Objects #36

Closed sAbakumoff closed 9 years ago

sAbakumoff commented 9 years ago

Hello, The upgrade guide at https://github.com/yahoo/fluxible-router/blob/master/UPGRADE.md is the great document and it helped me a lot on upgrading to the recent fluxible. However, it can improved further with the list of all the objects that became immutable. I.e. I found that the parameters passed in action function of the route are now immutable and instead of using something like

    customer :{
        method : 'get',
        path : '/customer/:id',
        page : pages.customer,
        action : function(context, payload, done){
          context.executeAction(getCustomerDetails, {filters : payload.params}, done);
        }
    }

I now have to use

filters : payload.get('params')

Thanks!

mridgway commented 9 years ago

Will make a not of this in the guide. Thanks!

mridgway commented 9 years ago

Added in https://github.com/yahoo/fluxible-router/commit/d300795ab8a3950b511df9898b22f24298caeb00