search

YahooArchive / fluxible-router

MOVED TO FLUXIBLE REPO
104 stars 26 forks source link

each navigateAction call increases history length by 2, stuffs up browser back button? #67

Closed mailaneel closed 9 years ago

mailaneel commented 9 years ago

Every navigateAction calls handleHistory:componentDidUpdate twice

first for NAVIGATE_START second for NAVIGATE_SUCCESS

Back button is not working properly because of this.

mridgway commented 9 years ago

Hi @mailaneel, could you look at https://github.com/yahoo/fluxible-router/issues/66 and see if this is the same issue you are seeing?

mailaneel commented 9 years ago

@mridgway thanks same issue.

I am using transform reverse on route to solve https://github.com/yahoo/fluxible-router/issues/65 which returns original url.

So when we compare they are do not match. Any Suggestions

Edit: Transform reverse: /?q=test#/comments => /comments?q=test

mailaneel commented 9 years ago

My bad works fine now, I was doing it in reverse instead of transform thanks once again @mridgway