search

YahooArchive / guerilla

Guerilla is a distributed build/test server specialized for iOS and Android.
MIT License
17 stars 8 forks source link

Mail Server Issue #51

Open nickwph opened 8 years ago

nickwph commented 8 years ago

Currently mailing service only works if it is configured in workers, not when it is configured in master.

Is it intended? @thekushpatel Since in wiki, it is written that mailing service should be configured in master.

thekushpatel commented 8 years ago

This looks like a bug, good catch.

I think the fix would be to change the documentation and the config.json.sample files so that the mailer is configured in the worker. Thoughts?

nickwph commented 8 years ago

i mean, should it be configured in master or worker? doing it in master may make more sense if guerilla only have 1 single mailing account. but if we want to have multiple mailing account, would it make more sense to make it configurable in each job?

BruceBGordon commented 8 years ago

I think it makes more sense for the mailer to be configured in the master. Allow an override in the job, but why burden the worker config with this? I want to maintain less.

nickwph commented 8 years ago

let's do it