Closed irae closed 7 years ago
Any reason why some packages are incremented to 3.0.1
while other are set to 3.1.0
??
Yes, this is semantic version. It's a good idea to read about it and get a good grasp of the concept.
The reason here is simple. Every package that got to 3.1.0 got a new feature. The feature we are adding is: support for global
shim that didn't use to work before. All other packages got only bugfixes, therefore they get only a "patch" version.
If we break any API we need to bump the major version.
Semver works like this so people can get bugfixes for free, new features with attention and breaking changes only when they know they need to change their code.
I pushed some stuff so we can test better:
published to prod, this is for mendel v1 users:
published with beta tag:
I'll be integrating this into my own project and pushing to production soon to test it and will report back.
Had to publish newer versions:
I fast forwarded this PR to master with current changes. I'll push new betas in a moment of the relevant packages soon and let you know. There is only the new warning/error.
Just published:
also updated the versions from previous comments so you there is no confusion
@muralikr works for me in both dev and production for my application. I think we are good to go. You tell me when we are good on your side, ok? Thanks a lot!
:+1:
On Mon, Jun 5, 2017 at 3:37 PM Irae Carvalho notifications@github.com wrote:
@muralikr https://github.com/muralikr works for me in both dev and production for my application. I think we are good to go. You tell me when we are good on your side, ok? Thanks a lot!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yahoo/mendel/pull/124#issuecomment-306330140, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFdl0N0LqQY0Uv4MWwaOkUtOQaqrws0ks5sBIMsgaJpZM4NvhFX .
-- Thanks & Regards,
Murali Krishna .B.
published
At this point, if I link all the packages I ran a lot of tests with a project recently migrated to mendel 3.x and everything seems to work fine.
I went through all the packages changes by git log and found all places that need bump. Most packages will go to 3.1 because we now support global shim and this is a new feature. Some packages tho I only bumped the patch version because we only include bug fixes.
I believe we have a solid release in hands for production. I'll push "beta" versions of those packages and mention in the comments in the next half-hour or so. I'll also try this version in production.
@muralikr @anuragdamle can you please make sure this version works for your application? Also, would you be so kind to pin to the exact version all packages in your application? This way the open source version can move faster, as discussed. Thanks!