YahooArchive / mojito

[archiving soon] Yahoo! Mojito Framework
BSD 3-Clause "New" or "Revised" License
1.57k stars 214 forks source link

views multiple devices example is missing selector configs in application.json #549

Closed tufandevrim closed 12 years ago

tufandevrim commented 12 years ago

The example at http://developer.yahoo.com/cocktails/mojito/docs/code_exs/views_multiple_devices.html is missing following config values in application.json:

{ "settings": [ "device:android" ], "selector": "android" }, { "settings": [ "device:blackberry" ], "selector": "blackberry" }, { "settings": [ "device:iphone" ], "selector": "iphone" }

zhouyaoji commented 12 years ago

Thanks for filing this issue. I've corrected the code snippets in the "Setting Up this Example" section and added documentation for using context configs and the 'selector' property in the "Implementation Notes" section. In addition, the example "Dynamically Adding CSS to Different Devices" was also missing the context "device:iphone" and the 'selector' property in both the implementation notes and steps: both have been corrected.