search

YahooArchive / omid

Transactional Support for HBase (Mirror of https://github.com/apache/incubator-omid)
http://omid.incubator.apache.org/
Apache License 2.0
302 stars 107 forks source link

Minor changes to project #22

Closed francisco-perez-sorrosal closed 11 years ago

francisco-perez-sorrosal commented 11 years ago

Small changes to cleanup code and some minor errors

dgomezferro commented 11 years ago

Thanks a lot for the cleanup!

I'm OK with merging, do you have more comments Flavio?

fpj commented 11 years ago

It looks great, thanks a lot for the changes, Francisco. It might be a good practice to add some description on top of new tests to state the purpose of the test. Although we can understand what it is doing by reading the code, it is difficult to make sure that future changes won't break it if we don't have a specification of what it is supposed to do.

francisco-perez-sorrosal commented 11 years ago

Hi Flavio. Instead of adding a description to the tests, in the two new tests I've added, I've followed the approach of putting as the name of the test, the purpose of it. I think that for tests that are not very complex, this approach is OK. For complex tests that require more information, I agree that comments are the best practice. What do you think?

dgomezferro commented 11 years ago

Please update the bin/omid.sh script to reflect the new placement of the native library.

dgomezferro commented 11 years ago

Great changes, thank you @francisco-perez-sorrosal !

Please merge