Please add filename to warning output

YahooArchive / secure-handlebars

Handlebars Context Pre-compiler

BSD 3-Clause "New" or "Revised" License

45 stars 13 forks source link

Please add filename to warning output #122

Closed jeremyruppel closed 9 years ago

jeremyruppel commented 9 years ago

Is it possible to include the offending template filename with the warning output? I made a change in our test suite and got a blast of errors like this:

[WARNING] SecureHandlebars: Unsafe output expression found at scriptable <script> tag
Please follow this URL to resolve - https://github.com/yahoo/secure-handlebars#warnings-and-workarounds [lineNo:45,charNo:869]

It would be very helpful to also include the path to the offending file along with the line and column numbers.

neraliu commented 9 years ago

PR for this - https://github.com/yahoo/secure-handlebars/pull/125

neraliu commented 9 years ago

it is now supported in secure-handlebars 1.1.1 and express-secure-handlebars 2.0.4