search

Yahweasel / libav.js

This is a compilation of the libraries associated with handling audio and video in ffmpeg—libavformat, libavcodec, libavfilter, libavutil, libswresample, and libswscale—for emscripten, and thus the web.
288 stars 18 forks source link

Cannot build h.264 #50

Closed Angramme closed 3 months ago

Angramme commented 3 months ago

I am trying to add support for H.264 aka AVC1 in my app because it is the most widely supported and common format right now, despite the issues with patents. I am trying to build the h264-aac-avf variant with the make build-h264-aac-avf command. It gets stuck at 

emcc: error: --memory-init-file is no longer supported.

(I have linked the error log log.txt). I wonder if I could get it to work with an older version of emscripten. Could you kindly provide the version number of emscripten you use to compile and test the variants? Or maybe im completely missing the issue and it is not in fact the version of emscripten.

Thank you in advance for your help :)

details:

I'm on the latest version of libav.js: commit 2525f3bdd49fe6ea7db6ad2e4e564c52a13c51cf (HEAD -> master, origin/master, origin/HEAD) GNU Make 3.81 NPM version 10.5.0 NODE v21.7.1 EMCC emscripten versions:

emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.55-git clang version 19.0.0git Target: wasm32-unknown-emscripten Thread model: posix InstalledDir: /opt/homebrew/Cellar/emscripten/3.1.55/libexec/llvm/bin

Yahweasel commented 3 months ago

Emscripten recently removed this flag. I was only using the flag to say not to use a memory init file, but annoyingly, when they removed the feature (what I wanted all along), they also removed the flag, even to say not to use it @_@ . I'll remove it from the Makefile.

(Regarding H.264, if I was so opposed to people using H.264 at all, I wouldn't have merged support for it. If you're so desperate to shoot yourself in the foot, be my guest.)

Yahweasel commented 3 months ago

Should be fixed in a405e8855109680cb3dd42501824681531e45c8d

Angramme commented 3 months ago

Thanks for solving it!