Added more accessors to struct AvCodecParameters.

Yahweasel / libav.js

This is a compilation of the libraries associated with handling audio and video in ffmpeg—libavformat, libavcodec, libavfilter, libavutil, libswresample, and libswscale—for emscripten, and thus the web.

288 stars 18 forks source link

Added more accessors to struct AvCodecParameters. #7

Closed pushpagarwal closed 1 year ago

pushpagarwal commented 1 year ago

These accessor would help to set stream codecpar values from javascript. It made possible to mux encoded packets from webcodecs encoder. So libav.js could be used for muxing mp4 with AAC1 audio (encoded using livav.js) and H.264 Video ( encoded using webcodecs).

pushpagarwal commented 1 year ago

@Yahweasel Could you please review this PR?

Yahweasel commented 1 year ago

@Yahweasel Could you please review this PR?

I did, the same day you made it. There is a pending review in the PR.

pushpagarwal commented 1 year ago

@Yahweasel I don't see any comments on the PR. Please let me know comments pending for me so that I can address those. Attaching screenshot of what I see on the PR. Thanks.

Yahweasel commented 1 year ago

Oy vey, GitHub gonna GitHub I guess.