test_client_publish_retain_subscribe fails

Yakifo / amqtt

Community driven LTS for HBMQTT

MIT License

137 stars 53 forks source link

test_client_publish_retain_subscribe fails #16

Open FlorianLudwig opened 3 years ago

FlorianLudwig commented 3 years ago

the test_client_publish_retain_subscribe test in tests/test_broker.py fail.

The QOS_0 message send during the test does not arrive.

HerrMuellerluedenscheid commented 3 years ago

That happens on master right? I reverted 734cbb8 because of that in the python3 refactor MR. That commit introduced some changes how QOS_0 is handled without taking care of the tests. This PR changes the testing logic to meet the changes in 734cbb8 https://github.com/beerfactory/hbmqtt/pull/236

HerrMuellerluedenscheid commented 3 years ago

However, I'm not fully convinced that the way changes introduced in the reverted commit honor the mqtt protocol correctly. Have a look at this thread https://github.com/beerfactory/hbmqtt/pull/213#commitcomment-45823488. What do you think?