search

Yakoo63 / gtalksms

Automatically exported from code.google.com/p/gtalksms
39 stars 18 forks source link

Detect equal numbers from joined contacts #167

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Enhancement Request:  (close to #166)

When I send a SMS to a name where  gTalkSMS find more than one person but 
having the same number, gTalkSMS should send the SMS anyway

sms:Lastname:This is a test SMS

 reply:  Spécifier plus de détails :
 Firstname Lastname - 0607070707
 Firstname Lastname - 0607070707

Because both numbers are the same, gTalkSMS shouls send the SMS

Original issue reported on code.google.com by lpenou.tstXX@mpo.li on 17 May 2011 at 11:59

GoogleCodeExporter commented 9 years ago 
If it's the same number, it's a bug.
It could append when the number hasn't have the same format (+33 6 vs 06)

Original comment by Florent....@gmail.com on 17 May 2011 at 12:54

GoogleCodeExporter commented 9 years ago 
@BugReporter: Is this a joined contact, e.g. meta contact composed out of 
different contact sources (Google, Facebook, Skpe, etc.)?

Original comment by fschm...@gmail.com on 21 May 2011 at 3:56

GoogleCodeExporter commented 9 years ago 
Yes
From different gapps accounts
Le 21 mai 2011 17:58, <gtalksms@googlecode.com> a �crit :

Original comment by lpenou.tstXX@mpo.li on 21 May 2011 at 3:59

GoogleCodeExporter commented 9 years ago

Original comment by fschm...@gmail.com on 21 May 2011 at 4:56

GoogleCodeExporter commented 9 years ago

Original comment by fschm...@gmail.com on 21 May 2011 at 4:57

GoogleCodeExporter commented 9 years ago 
Ignore duplicated phone number on database requests.

Original comment by Florent....@gmail.com on 10 Jun 2011 at 9:09

GoogleCodeExporter commented 9 years ago 
TY/merci

Original comment by lpenou.tstXX@mpo.li on 10 Jun 2011 at 9:23

GoogleCodeExporter commented 9 years ago 
Fixed in v2.2.4

Original comment by Florent....@gmail.com on 13 Jun 2011 at 1:24

GoogleCodeExporter commented 9 years ago 
I'm on 2.2.4 and I still have the issue 

sms:Laurent B:FooBar

Spécifier plus de détails :
Laurent B - +33686461637
Laurent B - +33686461637

:(

Original comment by lpenou.tstXX@mpo.li on 15 Jun 2011 at 8:21

GoogleCodeExporter commented 9 years ago 
I've test the fix with 2 phones in a Gmail contact.

Can you check for your contact in which account type are the phones ? 
(Facebook, gmail, exchange...?)

Original comment by Florent....@gmail.com on 15 Jun 2011 at 7:33

GoogleCodeExporter commented 9 years ago 
a contact who is
 - in two gapps accounts
 - in a gapps and a Facebbok account 

I think it works for the other contacts who are only in gapps accounts

Original comment by lpenou.tstXX@mpo.li on 15 Jun 2011 at 7:41

GoogleCodeExporter commented 9 years ago 
In your contact manager do you see 1 or 2 contact (in call application by 
instance) ?
(To know if you have merge contact or distinct contacts)

Original comment by Florent....@gmail.com on 15 Jun 2011 at 7:55

GoogleCodeExporter commented 9 years ago 
I have 2 contacts each are already the merge of multiple contact / identites

Original comment by lpenou.tstXX@mpo.li on 15 Jun 2011 at 9:20

GoogleCodeExporter commented 9 years ago 
Can you try with GTalkSMS v2.2.4.1 Beta available in download section ?
I've add another check for the distinct contacts. The Contact Google API may 
return different contacts for a merged one.

Please, keep me posted for the result

Original comment by Florent....@gmail.com on 17 Jun 2011 at 8:37

GoogleCodeExporter commented 9 years ago

Original comment by Florent....@gmail.com on 17 Jun 2011 at 8:38

GoogleCodeExporter commented 9 years ago 
It Works !!!! 

Thanks

Original comment by lpenou.tstXX@mpo.li on 17 Jun 2011 at 9:02

GoogleCodeExporter commented 9 years ago 
Nice !

Original comment by Florent....@gmail.com on 17 Jun 2011 at 9:15

GoogleCodeExporter commented 9 years ago 
Fixed in v3.0

Original comment by Florent....@gmail.com on 15 Jul 2011 at 3:35

GoogleCodeExporter commented 9 years ago

Original comment by fschm...@gmail.com on 25 Aug 2011 at 7:50

GoogleCodeExporter commented 9 years ago 
With 3.3.3 there is an old issue back 

 Spécifier plus de détails :
 Yves - +3366342XXYY 
 Yves - 066342XXYY

Original comment by lpenou@m4p.li on 5 Jan 2012 at 8:57

GoogleCodeExporter commented 9 years ago

Original comment by fschm...@gmail.com on 5 Jan 2012 at 9:43

GoogleCodeExporter commented 9 years ago 
Hmm the numbers are distinct. One has an country code prefix the other hasn't. 
Are you sure that this did work with 3.3? I don't think that we have an logic 
in GTalkSMS that detects similar numbers with different formats (local vs. 
canonical number format).

Is one of the numbers market as default number?

Original comment by fschm...@gmail.com on 6 Jan 2012 at 2:14

GoogleCodeExporter commented 9 years ago 
I'm quite sure it was working, but difficult to check because I corrected the 
number on the phone. 
But the phone I think has the availability to make relation between 066342XXYY 
and 3366342XXYY

If I put someone in the phone with the format 066342XXYY
and if I receive a call from +3366342XXYY
the phone display the correct name of the calling person 

Also I think the algorithm exist with smsBackup+ 
https://github.com/jberkel/sms-backup-plus/

Original comment by lpenou@m4p.li on 7 Jan 2012 at 4:34