search

Yalantis / GuillotineMenu-Android

Neat library, that provides a simple way to implement guillotine-styled animation
https://yalantis.com/
2.72k stars 495 forks source link

Problem with open angel #5

Closed moali2402 closed 9 years ago

moali2402 commented 9 years ago

There seems to be a problem with the Open angel of the menu. I can see a bit from the main view from the right of the screen. So its like over opened.

Issue 2 :

if i use setClosedOnStart() to true, the hamburger button animation doesn't work

dmytroDenysenko commented 9 years ago

@moali2402 Can you provide more info about this "angle" issue? What kind of device do you use, screenshot, some code? As for "Issue 2", I will look into it ASAP.

occamz commented 9 years ago

The first issue is solved in https://github.com/Yalantis/GuillotineMenu-Android/issues/7.

I am interested in any pointers on how I could fix the setClosedOnStart() issue. Got any tips?

fillbirdpa commented 9 years ago

if i use 'setClosedOnStart(true) ', closingView and openingView have no animation effect。

fillbirdpa commented 9 years ago

@occamz i found the problem, fix code in GuillotineAnimation.java like the following

if (builder.isClosedOnStart) { mGuillotineView.setRotation(GUILLOTINE_CLOSED_ANGLE); mGuillotineView.setVisibility(View.INVISIBLE); }

The problem is：if use GONE ，'closingView' can not get width & height in the method ‘setUpClosingView(final View closingView)’ .

occamz commented 9 years ago

@fillbirdpa Thank you. Figured it might've been something like that.

dmytroDenysenko commented 9 years ago

@fillbirdpa thanks for solution, will add it in an update