search

Yalantis / Phoenix

Phoenix Pull-to-Refresh
https://yalantis.com/
Apache License 2.0
4.01k stars 916 forks source link

Adding Simple Drawable - you can load the image from a drawable #4

Closed franzejr closed 9 years ago

franzejr commented 9 years ago

I think it could be good have a kind of load from a resource. So, I've created a new RefreshView called SimpleDrawableRefresh and I pass the drawableName. Using this, the drawable will be loaded.

shliama commented 9 years ago

So, basically you've removed all the code that works with background images and added ability to pass custom drawable to the RefreshView. Foremost, you should rename method from "drawSun" to for example "drawCustomImage", and so on. Second, you should add this type to the attrs.xml, so this type can be chosen inside layout. Also, now this "drawable" spins just at the position of the sun ... maybe it should be centered? And one more thing, user must be able to pass drawable name not from library code, but from his own code. At the moment, "custom" drawable name is hardcoded in the PullToRefreshView that is no even accessible when you add this library as gradle dependency.

Anyway, thanks for the contribution, will be waiting for fixed pull request (please make following requests to "dev" branch). Cheers (❍ᴥ❍ʋ)

franzejr commented 9 years ago

Yeah! I just forked and created my own version.. Thanks for contributing too and help me =) See ya!