search

Yalantis / Phoenix

Phoenix Pull-to-Refresh
https://yalantis.com/
Apache License 2.0
4.01k stars 916 forks source link

Fixing PR - Making PullRefresh using Custom Image #5

Closed franzejr closed 9 years ago

franzejr commented 9 years ago

I've removed all the code that works with background images and added ability to pass custom drawable to the RefreshView.

About my last PR:

As you told me, making this new PR on "dev" branch. Do you think it's ok now ?

shliama commented 9 years ago

Foremost, let me gime some comments on PR:

  1. We use https://source.android.com/source/code-style.html
  2. You've changed package name to "com.simplepulltorefreshexample" - for sure I won't be able to merge this...
  3. customImageName is used in the constructor, so it will be null and setter is kinda useless.
  4. Still can't see any changes in attrs.xml, have you commited them?

And the second part. I've discussed your proposal with my team, and we decided not to add this feature to the library. I'll expalin why:

  1. This lib was created as easy to implement component with rich graphics, that corresponds to our company's design.
  2. Soon other refresh styles will be added to the lib.
  3. Your proposal does not add any new things to the lib, just simplifying it. Also there are couple libs on github that can just rotate/transform some views/drawables in pull-to-refresh maner.

Of course, it's opensource and you are free to fork/change or do whatever you want with this code. Hope you're not disappointed about it.

Peace (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧