search

Yalantis / Phoenix

Phoenix Pull-to-Refresh
https://yalantis.com/
Apache License 2.0
4.01k stars 916 forks source link

PullToRefreshLayout is always visible #9

Closed DavidPacioianu closed 9 years ago

DavidPacioianu commented 9 years ago

PullToRefreshLayout should be visible only when you start dragging it down. Now it is always visible and I have to set the background of the recyclerView to 100% opacity.

shliama commented 9 years ago

Can you give more details? -Now (after last update)? -Always visible? For me - it's not. Screenshot or video would be great.

HamedMP commented 9 years ago

I have the same problem, tried with the setVisibility(View.INVISIBLE) but the whole listview gone invisible. The problem is as follow: -When there is no item in Listview, the animation is shown, even without pulling (in fact you can't even pull it to refresh) -When there is an item, you can see the images of the animation from the margin between the rows, if there is only one row, you can see half of the image which is so awful. please help us to hide them while we don't need them. Btw, thank you for such a beautiful library. 1 2

shliama commented 9 years ago

@DavidPacioianu @HamedMP now it is clear :) I've updated the "dev" branch with a fix for this issue. It would be great if you pull it and try in your projects. I've also spend some time to test it. If everything is ok - I'll update the maven repo too.

HamedMP commented 9 years ago

I'll try to check it at the moment and let you know, but before that, I just updated to version 1.1.2 and the problem solved 50%, without any interaction to listview, the animation is not shown, but when you touch it or ..., it shows again, so only when the view is created everything is ok until you touch something.

Btw, is there a way to use DEV branch from Gradle or we should download the source and compile it on our owns?

shliama commented 9 years ago

@HamedMP now it's only possible to include dev branch as module to your project. Sample uses it in this way too, so you can check how it's done.

DavidPacioianu commented 9 years ago

@shliama I have tried the dev branch module and the recyclerView padding is no longer working and the only thing that happens now is to make the recyclerview opaque, which is not what I expected ( I expected that the refreshLayout will be invisible) and because of that , if set a top margin for the list item it (the margin) becomes opaque and will cover a part of the refreshLayout. device-2015-04-13-194945

shliama commented 9 years ago

@DavidPacioianu I haven't tested the library with recyclerView yet. Gonna do this asap (at the moment I don't have enough free time) and post an update here.

alokedesai commented 9 years ago

Any update on this? I'm having the same problem. This is what it looks like for me: image

shliama commented 9 years ago

@alokedesai do you use RecyclerView? If not - try to use dev branch, this issue must be fixed there. I haven't tested this lib with RecyclerView and at the moment I do not have time to do this. Any pull-requests with fixes will be appreciated :)

PGMacDesign commented 9 years ago

First off, amazing job on this project. Animation looks incredible.

I too am using this with the RecyclerView (Specifically android.support.v7.widget.RecyclerView) and it looks exactly as alokedesai's does where the image end up taking up a section of the background. Just wanted to ping it as well as I look forward to including this in my app once that recyclerView problem gets solved. -Pat

shliama commented 9 years ago

@PGMacDesign @alokedesai I've just updated master branch and maven repo with version 1.2.0. You can check out the new sample with both ListView and RecyclerView examples. Please leave a feedback if you have any issues with the library.

HamedMP commented 9 years ago

Wow, Thank you very much, it's solved ^_^ (The problem with listview solved)

On Sat, May 30, 2015 at 6:03 PM, Oleksii notifications@github.com wrote:

@PGMacDesign https://github.com/PGMacDesign @alokedesai https://github.com/alokedesai I've just updated master branch and maven repo with version 1.2.0. You can check out the new sample with both ListView and RecyclerView examples. Please leave a feedback if you have any issues with the library.

— Reply to this email directly or view it on GitHub https://github.com/Yalantis/Phoenix/issues/9#issuecomment-107039157.

PGMacDesign commented 9 years ago

Shliama, fantastic work! It is flawless with a recyclerview now. Thank you so much for your time and brilliance with this Library.