Yalantis / PullToMakeSoup

Custom animated pull-to-refresh that can be easily added to UIScrollView
https://yalantis.com/
MIT License
1.92k stars 213 forks source link

Simultaneous Access issue #28

Open AdamMoffitt opened 6 years ago

AdamMoffitt commented 6 years ago

Report a bug

In line 98 and 126 of PullToRefresh.swift, the following warning is generated: Simultaneous accesses to 0x104e18828, but modification requires exclusive access

line 98: if (context == &KVOContext && keyPath == contentOffsetKeyPath && object as? UIScrollView == scrollView) {

line 126: else if (context == &KVOContext && keyPath == contentSizeKeyPath && object as? UIScrollView == scrollView) {

I believe this is an issue from Swift 4 monitoring simultaneous access more carefully.

Your Environment

Stack

   CocoaPods : 1.3.1
        Ruby : ruby 2.3.3p222 (2016-11-21 revision 56859) [universal.x86_64-darwin17]
    RubyGems : 2.5.2
        Host : Mac OS X 10.13.4 (17E199)
       Xcode : 9.4 (9F1027a)
         Git : git version 2.15.1 (Apple Git-101)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ d216389487cda4da0b37deddcb79b5f6373ede58

Installation Source

Executable Path: /usr/local/bin/pod

Plugins

cocoapods-deintegrate : 1.0.2
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.0
cocoapods-try         : 1.1.0

Podfile

# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

target '' do

  pod 'PullToMakeSoup', '~> 2.0'
end
sanketfirodiya commented 5 years ago

As a temporary workaround, I have removed the exclusive access check in build settings:

screen shot 2018-09-23 at 11 07 02 pm
AdamMoffitt commented 4 years ago

@sanketfirodiya is this still working for you? I dont see no enforcement as an option as of xcode 10

AdamMoffitt commented 4 years ago

Even when I turn all exclusive access to memory off i still get the same issue