search

Yale-LILY / SummerTime

An open-source text summarization toolkit for non-experts. EMNLP'2021 Demo
https://arxiv.org/abs/2108.12738
Apache License 2.0
264 stars 30 forks source link

Added meteor metric #34

Closed zhangir-azerbayev closed 3 years ago

niansong1996 commented 3 years ago

Isn't METEOR available in SummEval as well, any particular reason that we are not using them? (but it's okay if the current version works

zhangir-azerbayev commented 3 years ago

@niansong1996 I chose not to use the SummEval version because it depends on having Java installed.

niansong1996 commented 3 years ago

I see, then this is a reasonable solution.

On Wed, Jun 23, 2021 at 13:49 zhangir-azerbayev @.***> wrote:

@niansong1996 https://github.com/niansong1996 I chose not to use the SummEval version because it depends on having Java installed.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Yale-LILY/SummerTime/pull/34#issuecomment-867038939, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTNUGS5FHYLAZIFV6J3BADTUINDFANCNFSM47GIP6GA .

niansong1996 commented 3 years ago

@zhangir-azerbayev Can you add a test case for this metric?

zhangir-azerbayev commented 3 years ago

@niansong1996 The evaluation unit test automatically tests every metric in SUPPORTED_EVALUATION_METRICS. Is this what you mean?

niansong1996 commented 3 years ago

I see, then have this passed the tests?

zhangir-azerbayev commented 3 years ago

@niansong1996 After Troy's fixes to the script we discussed in the previous meeting, the tests will pass.

niansong1996 commented 3 years ago

Okay then, let me merge this for now