Yale-LILY / SummerTime

An open-source text summarization toolkit for non-experts. EMNLP'2021 Demo
https://arxiv.org/abs/2108.12738
Apache License 2.0
269 stars 30 forks source link

murori/combine huggingface and non-huggingface datasets #64

Closed MuroriM closed 3 years ago

MuroriM commented 3 years ago

Put all datasets together, add simple and detailed functions to prin…t the supported datasets

niansong1996 commented 3 years ago

@MuroriM I noticed that you accidentally uploaded the *.lock files to the github.

To remove it, do it in this order:

  1. remove all *.lock files in the datasets locally;
  2. commit the changes and push to github;
  3. add *.lock to .gitignore;
  4. commit the change on .gitignore and push
MuroriM commented 3 years ago

@niansong1996 I deleted the '*.lock' files but the files were still showing up in the 'Files changed' tab as empty files instead of deleted files. I tried fixing this with the last four commits but it seems this is a standard operation and the files are successfully deleted. I, however, have linked two unrelated issues when trying to number the commits. From the GitHub documentation, there doesn't seem to be a way to unlink the issues.

niansong1996 commented 3 years ago

It's okay as long as it's deleted from the git files.

I unlinked the irrelevant issue. You can click the linked one to unlink it: image

Btw, I am not sure why you deleted every *.lock file with a separate commit, you know you can change multiple files in one commit, right ;) ? It doesn't matter that much, but every time you commit it will trigger a separate build (and I am getting an email lol

MuroriM commented 3 years ago

@niansong1996 My bad. Will fix that going forward

niansong1996 commented 3 years ago

Is this ready for review/merge?

MuroriM commented 3 years ago

It's ready for review