search

YaleDHLab / intertext

Detect and visualize text reuse
https://duhaime.s3.amazonaws.com/yale-dh-lab/intertext/demo/index.html
115 stars 10 forks source link

Adjust requirements.txt path as we have just cd'd #21

Closed pleonard212 closed 6 years ago

duhaime commented 6 years ago

@pleonard212 this confused Cathy too. The full readme says:

# clone the application source code
git clone https://github.com/YaleDHLab/intertext

# install the Python dependencies
cd intertext && pip install -r intertext/requirements.txt --user

# install the node dependencies
npm install --no-optional

# detect reuse in the included sample documents
npm run detect-reuse

# start the web server
npm run production

When users run step two, they cd into intertext, but the relative path to requirements.txt is still intertext/requirements.txt. Is that too confusing? I like the idea of keeping the Python reqs with the Python source rather than the app source, but maybe we should move requirements.txt to intertext/requirements.txt rather than intertext/intertext/requirements.txt. What do you think?

pleonard212 commented 6 years ago

Ah, you know what happened on my machine was the first command succeeded and the seconded failed b/c I was in a venv. Trying again cause an error because the first CD succeeded! So agree no need for this change.

duhaime commented 6 years ago

Given that this has been confusing on two occasions, I think we should move requirements.txt to the root dir...