Closed duhaime closed 6 years ago
Makes sense! We didn't have form validation before but I'll check with Elihu about the requirements.
Excellent, thank you
Just a quick note to say there appear to be dozens of empty building stubs expressed in the client (if one scrolls down a bit):
Thanks for the heads up - I checked in with Them yesterday and they want some significant changes to the building entry form again (which will again require a model change/migration) but there are three required fields. I’ll work on it over this weekend and reject any building stubs that do not include those three fields.
On Feb 9, 2018, at 1:51 PM, Douglas Duhaime notifications@github.com wrote:
Just a quick note to say there appear to be dozens of empty building stubs expressed in the client (if one scrolls down a bit):
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
That sounds good @spaceraccoon!
To be fixed in #335 - googledoc specifying form/model changes are in there as well.
Resolved with #336
@spaceraccoon Hey Eugene! It's great you've landed so many PR's on this app--thanks for that! It might be worth revisiting #317 though, as dropping that requirement leads to strange display properties:
Are you talking with Elihu about requirements? If so and he's comfortable with the displays above, this can be closed, else maybe we should ping him to ask if he has minimal building features that should be present to facilitate display?