Refactor decorators for equipment models and equipment items

YaleSTC / reservations

Manage equipment loans & reservations. Who can borrow what, for how long?

yalestc.github.io/reservations

MIT License

139 stars 57 forks source link

Refactor decorators for equipment models and equipment items #1148

Open orenyk opened 9 years ago

orenyk commented 9 years ago

We should be using the class methods for EquipmentModel and Reservation to avoid DB calls if possible (and avoid code duplication). Things to try and get rid of:

[ ] EquipmentModel#available_count
[x] EquipmentModel#number_overdue
[ ] the ActiveRecord query in equipment_model_decorator.rb

orenyk commented 8 years ago

@esoterik - how does this fit in with #1501? Have these all largely been taken care of?

esoterik commented 8 years ago

Just saw this!

The other availability methods use the minimum number of queries possible; a potential improvement would be to have a counter cache of equipment items on each model
EquipmentModel#number_overdue has been replaced by a counter cache

orenyk commented 8 years ago

Nice, so this is just a matter of improving the decorators then? Sounds good!