Potential issue with requirements in the catalog

[orenyk]

I, [2018-06-27T16:22:40.758219 #21770]  INFO -- : Completed 500 Internal Server Error in 125ms (ActiveRecord: 54.7ms)
F, [2018-06-27T16:22:40.759168 #21770] FATAL -- :   
F, [2018-06-27T16:22:40.759271 #21770] FATAL -- : NoMethodError (undefined method `list_requirement_admins' for RequirementsHelper:Module):
F, [2018-06-27T16:22:40.759332 #21770] FATAL -- :   
F, [2018-06-27T16:22:40.759394 #21770] FATAL -- : app/controllers/application_controller.rb:268:in `block in prepare_catalog_index_vars'
app/controllers/application_controller.rb:257:in `prepare_catalog_index_vars'
app/controllers/catalog_controller.rb:27:in `index'

[orenyk]

You will likely need to have an EquipmentModel with a requirement defined showing in the catalog in order for this to break (maybe?)

[ccadden]

Issue is that we are calling the method directly from the module in application controller: https://github.com/YaleSTC/reservations/blob/ef2e4bd1595630438593b913c66954fb7bb8593a/app/controllers/application_controller.rb#L268

[mattcosh]

To do:

• import that method from the RequirementsHelper
• remove sanitize (the safe_join should already sanitize anyway)