search

YaleSTC / reservations

Manage equipment loans & reservations. Who can borrow what, for how long?
yalestc.github.io/reservations
MIT License
139 stars 58 forks source link

Fixing 500 error caused by requirements #1731

Closed ccadden closed 6 years ago

ccadden commented 6 years ago

Closes #1730

orenyk commented 6 years ago

@mr-sigma also, looks like there's a newline missing in the new file as well (see the failed build). You can also squash these commits down into one and then we can merge. Thanks!

ccadden commented 6 years ago

Does rubocop only check the changed files for the CI job? I copied the spacing convention from another feature spec.

orenyk commented 6 years ago

@mr-sigma yes it checks only changed files, that's why the other files weren't flagged. That way we can slowly improve style as we update the codebase rather than trying to do it all at once.