YaleSTC / reservations

Manage equipment loans & reservations. Who can borrow what, for how long?
yalestc.github.io/reservations
MIT License
139 stars 57 forks source link

Items Per Page & Show _ Entries #262

Closed caseywatts closed 10 years ago

caseywatts commented 12 years ago

These two should be paginated ~the same way, and have the same (or different) @app_settings variable(s).

I can't tell where "show _ entries" comes from, but it appears on a lot of the tables in the app, such as: http://ulua.its.yale.edu/stc-loaners/categories/1/equipment_models

mnquintana commented 12 years ago

The Show _ Entries comes from jQuery.DataTables, which unfortunately we can't really use for the Catalog, because it's not and won't work as a table. What we can do is set up AJAX pagination for the Catalog, so it's similarly responsive, and mimic the styling of the Show Entries form for Items Per Page.

adambray commented 12 years ago

Yeah, I think that your suggestion makes sense.

The one thing we need to be careful of is what type of ajax-ification we do. Specifically, we need to be mindful that we're not pre-loading all catalog items initially, since there's a performance hit from loading the availability of each object. That said, I've been reading up more on caching in rails, and I think we can effectively cache the availability partials for each item, and only change them when a reservation associated with that item is created or modified (checked in/out, dates, etc).

-Adam

On Nov 3, 2012, at 12:14 PM, Machiste N. Quintana notifications@github.com wrote:

The Show _ Entries comes from jQuery.DataTables, which unfortunately we can't really use for the Catalog, because it's not and won't work as a table. What we can do is set up AJAX pagination for the Catalog, so it's similarly responsive, and mimic the styling of the Show Entries form for Items Per Page.

— Reply to this email directly or view it on GitHub.

squidgetx commented 10 years ago

We should just update kaminari when we upgrade to rails 4