YaleSTC / reservations

Manage equipment loans & reservations. Who can borrow what, for how long?
yalestc.github.io/reservations
MIT License
139 stars 57 forks source link

Auto-Image Compression #545

Open squidgetx opened 10 years ago

squidgetx commented 10 years ago

I was thinking about small ways to improve loading times and general speed/responsiveness of Reservations, and I think there are a few things that we can do fairly easily (and some less fairly easily) to dramatically cut down on the amount of information served per page request.

My apologies if any of these issues have already been discussed but I couldn't find anything with a quick search

orenyk commented 10 years ago

Great ideas! I especially like the image conversion one; if we could easily add it into the uploading process so that admins wouldn't have to think about it at all that would be great. In terms of catalog navigation, we might want to have a UX brainstorming session later in the summer / interview our current users to get a sense of what the ideal home page / catalog would look like; I definitely think there's lots of room for improvement.

squidgetx commented 10 years ago

Renaming the issue, let's use this thread to focus on the image compression feature since changing the catalog layout is its own big thing and I think rails also auto minifies JS (sort of, it also fills it with a metric ton of comments)

Anyway, Casey suggested the smusher gem in Slack for lossless compression. It does everything over the cloud (also requiring http gem or something), which I'm sort of critical of. Also I was only able to get 8% compression or so on the test pngs generated by db:seed.

We already have imagemagick because of paperclip so we might as well use it; I doubt most users are going to be bothered by lossy jpg compression

mnquintana commented 10 years ago

The JS is minified already, although we could change the minify config to strip out comment too (I think block comments are untouched by default for license reasons).

I definitely agree that we should be compressing images, and that we should use ImageMagick to do it instead of adding an unnecessary cloud dependency.

orenyk commented 9 years ago

This never happened, but would definitely be of use given our relatively slow production servers (or at least they seem that way). Re-labeling / assigning medium priority - we should try to get to it this year.