[Rails 4.1 part 2] Begin removing Rails 4 transition gems

[squidgetx]

gem 'activerecord-session_store'
gem 'protected_attributes'
gem 'rails-observers'
gem 'actionpack-page_caching'
gem 'actionpack-action_caching'
gem 'activerecord-deprecated_finders'
gem 'rspec-its'

Likely we can remove page/action caching straight away, meanwhile protected_attributes and deprecated_finders will take a little work set up properly.

Active-record-sessionstore will have to stay until we figure out cookiestore, which should probably be its own issue.

Other things that need to be done to complete the transition to rails 4

• Explicity enable 'It should' syntax (or make everything use expect...)
• Remove duplicated shared example groups

also, double check that paperclip works

[orenyk]

Two deprecation warnings from the rails_41 branch:

Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /home/oren/ruby_projects/STC/reservations/spec/requests/announcements_spec.rb:8:in `block (2 levels) in <top (required)>'.

Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /home/oren/ruby_projects/STC/reservations/spec/controllers/requirements_controller_spec.rb:10:in `block (2 levels) in <top (required)>'.

Also, the duplicated shared example groups issue is already present in #650, so we can deal with that part separately.

[squidgetx]

Confirmed we can remove page/action caching as well as rails-observers

[squidgetx]

Removed aforementioned gems in #774

[squidgetx]

• Protected attributes in #826
• Deprecated finders in #827
• rspec its/should syntax should be doable with transpec, but we should wait until the above two are merged
• activerecordsessionstore deserves its own issue, probably
  • figure out if cas single-point logout breaks without ARsession store (do we need single point logout?)
  • figure out how2cookie encrypt. likely the production secret key will need to become a deployment-level concern (every sysadmin whos running reservations will use their own production secret key)

[squidgetx]

Closing, since the last two gems that need to be removed are in their own PRs #904 and #881