search

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Time Slots Tooltip #253

Closed caseywatts closed 10 years ago

caseywatts commented 10 years ago

On branch rails_3.2

  1. I can't create Time Slots from http://shifts.yale.edu/stcdev/time_slots/ - the tooltip shows me the "New Shift" popup instead.
  2. I /can/ create Time Slots here: http://shifts.yale.edu/stcdev/time_slots/new !!
  3. When there is a time slot, it shows up on http://shifts.yale.edu/stcdev/shifts

It's just a tooltip rendering issue probably~

shippy commented 10 years ago

Case 1 doesn't even show a popup/tooltip anymore.

shippy commented 10 years ago

Correction: when there is a timeslot available on Sunday (only day displayed as per #312), the clickthrough goes to time_slots/:id/edit rather than rendering a pop-up, which is an acceptable workaround. We should wait to close this until #312 is resolved.

thomasweng15 commented 10 years ago

Just a heads up, the fix for this issue by @njlxyaoxinwei redirects to timeslots/new when you click on the time slots schedule instead of displaying the tooltip. I have been working on getting tooltips working on the shifts schedule (#335) and I think I can get the correct timeslots tooltip to appear after working on the shifts version. There are still a number of issues that I'm figuring out, but it should be possible to restore the full functionality with a little time.

njlxyaoxinwei commented 10 years ago

As of now on branch 335 , tooltip.js for timeslots is restored to the following status:

  1. TimeSlot creation (ajax form) works on tooltip
  2. recurring TimeSlot creation (non-ajax form) works on tooltip
  3. Delete links for repeating TimeSlots (non-ajax button) work on tooltip
  4. Edit timeslot (ajax form) works correctly on tooltip
  5. Delete links for ordinary and repeating TimeSlots do not work yet. The one for ordinary TimeSlots should just trigger a confirm box and the one for repeating TimeSlots should trigger a tooltip with three deleting options.
  6. Delete link for ordinary TimeSlots (non-repeating) on tooltip edit form does not work yet, it redirects to show page.
  7. Error message display is part of a bigger issue, see #383
thomasweng15 commented 10 years ago

My two recent commits to branch 335:

  1. Clicking on the schedule in the time slots view opens a 'Add New Timeslot' tooltip instead of the 'Add New Shift' tooltip that was appearing before.
  2. The layout of the timeslot schedule was malformed but it should be fixed now (that whole area of code is pretty duplicated and mangled though >.<).
thomasweng15 commented 10 years ago

I thought I commented during my last shift, but point number 1 above is actually intended behavior and I have since reverted the change.

shippy commented 10 years ago

Closed via #393.