Cannot create new stickies

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.

MIT License

23 stars 18 forks source link

Cannot create new stickies #255

Closed njlxyaoxinwei closed 10 years ago

njlxyaoxinwei commented 10 years ago

The "post a new sticky" link does not work. Clicking the link leads to an error page.

njlxyaoxinwei commented 10 years ago

This issue involves several different problems:

Clicking the link should open up a modal window. It is realized by thickbox.js in the old versions. But it is not included in the asset pipeline in rails-3.2
Deprecated methods in notice model, sticky views and notice views
Deprecated create.js.rjs sticky view.

njlxyaoxinwei commented 10 years ago

I resolved each of the problems by:

include thickbox-compressed.js in the asset pipeline. However, it is a very old jQuery plugin and I had to replace the deprecated jQuery method $.browser with an alternative. I also changed it to a erb file to include the path to the loading gif properly, since in production rails will add hashes to filenames to enable caching.
Fix some instances of add_to_base, form_remote_for and save(false)
write create.js.erb and delete create.js.rjs in sticky view folder

njlxyaoxinwei commented 10 years ago

The code is in branch 255_stickies. It is built upon #235 (for access to the report show page that contains the link that creates new stickies ) and #254 (for rearranging the vendor assets).