search

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Incorrect Mobile View #256

Closed njlxyaoxinwei closed 10 years ago

njlxyaoxinwei commented 10 years ago

Right now the Shifts Mobile View is not right:

  1. It still has two columns instead of one, and it does not scale well. (see screenshots below)
  2. the modals are still being triggered in mobile view when posting notices etc.
    • Correct layout (from Dev Shifts):

screenshot from 2014-05-12 10 31 10

jasonkliu commented 10 years ago

I tried to look at this on branch 252_superfish which is built on #234, asset_pipeline_stylesheets. Using Chrome 37.0.2008.2 dev on OSX 10.9.2, I am able to change the browser's user agent using the addon here https://chrome.google.com/webstore/detail/user-agent-switcher-for-c/djflhoibgkdhkhhcedjiklpkjnoahfmg?hl=en-US but I am unable to replicate the results in this issue.
Are we able to deploy a recent version of the server to heroku or something similar so we can troubleshoot on a genuine mobile device? I believe the test targets are iOS, Android, and Windows Phone; I'm pretty sure there's no difference between user agent views on different Android versions but I'm not completely sure about iOS 6 vs 7. Targeting iOS 7 is probably the better option.

mnquintana commented 10 years ago

We should completely scrap the current implementation of mobile view and just work on finishing implementing Bootstrap (#273) and creating a proper responsive design instead.

mnquintana commented 10 years ago

See #320