search

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

258 Fix gem and plugin issues #278

Closed jasonkliu closed 10 years ago

jasonkliu commented 10 years ago

Fix #258 - remove gem jazz hands and replace with gem pry-byebug depending on ruby -v Fix #279 - remove plugin dynamic_form and replace with gem dynamic_form Fix #130 - remove plugin multiple_select and replace with gem simple_form Fix #290 - Deprecated: ActiveSupport::SecureRandom to SecureRandom

For the future: Fix #134 - remove plugin simple_time_select (wait for branch merges) Fix #280 - remove plugin rails_upgrade (still need to upgrade fully before removing)

dgoerger commented 10 years ago

I think we can merge this, however.

nvm just saw Jason's comment at the top that this is not done.

dgoerger commented 10 years ago

I think we should also remove .ruby_version and .rbenv_version, as they manually specify the ruby version as 1.9.3, although that could be in #289.

jasonkliu commented 10 years ago

Current status on this pull request:

It's mergeable. By the "for the future" above, I meant that it should be merged and then the two issues listed above should be reopened in a new pull request. It's not really possible to fix those or remove them until we have a merged branch - otherwise, dealing with merge conflicts will be more trouble than it's worth.

I support removing the blocks and I'll do that in a little bit it's done.

Removing .ruby-version and .rbenv_version should only be done when we are sure that everything works on different ruby versions. For that to be complete, the test suite needs to be fixed (#281).

dgoerger commented 10 years ago

The Ruby version can be specified in the Gemfile itself (as in Reservations, which does not have these files). Do .rbenv_version or .ruby_version get called anywhere? I just find it odd the way we're specifying the Ruby version in these two separate files, instead of in the Gemfile like we do with Reservations.

jasonkliu commented 10 years ago

.rbenv_version isn't called anywhere if I remember correctly, but .ruby_version sets the ruby version that will be used by rbenv.

When you do something like specify ruby 1.9.3 in your Gemfile, I believe it automatically sets the latest patch level, which is 1.9.3-p547. I'm not sure this upgrade can be made until we are sure that everything works - currently, we only know that Shifts works on 1.9.3-p374. The intermediate patch versions are p385, p392, p429, p448, p484, and p545, where many changes were made.