ActiveSupport::Memoizable is deprecated

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.

MIT License

23 stars 18 forks source link

ActiveSupport::Memoizable is deprecated #284

Closed jasonkliu closed 10 years ago

jasonkliu commented 10 years ago

DEPRECATION WARNING: ActiveSupport::Memoizable is deprecated and will be removed in future releases,simply use Ruby memoization pattern instead. (called from extend at app/models/user.rb:42)

jasonkliu commented 10 years ago

Couple options here: https://stackoverflow.com/questions/9132197/ @caseywatts @mnquintana Any preferred option?

Gem Memoist

require 'memoist'
extend ActiveSupport::Memoizable -> extend Memoist

Remove the Deprecation warning

ActiveSupport::Deprecation.silence { extend ActiveSupport::Memoizable }

Rewrite the methods using ||=, something like this commit

jasonkliu commented 10 years ago

Method 2 is probably not the best idea. Nominating Method 1 for right now, then possibly upgrade to Method 3. It only affects one file, so either should not be too difficult.