search

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Error on first-run LDAP config #309

Closed mnquintana closed 9 years ago

mnquintana commented 10 years ago

If you choose to configure LDAP in the first-run app config, then once you proceed past step 2 (naming your department), the app raises this error:

NoMethodError at /firstrun/first_user
undefined method `observe_form' for #<#<Class:0x007fc2be042f30>:0x007fc2c2651120>

app/views/first_run/_form.html.erb L:49

@dgoerger and I discovered that the observe_form method was provided by prototype and has been deprecated since Rails 2.3.8

Apparently the rails_upgrade plugin missed a lot of stuff (and so did we).

mnquintana commented 10 years ago

http://www.alfajango.com/blog/rails-prototype-to-jquery/

Okay so it looks like we're doing an AJAX form submit for the LDAP form with the old Prototype method... for no reason. Why is it an AJAX submit? It's an app config wizard - there is absolutely no reason why it couldn't just be a normal page load.

mnquintana commented 10 years ago

@shippy you should check with STC management, but I think the consensus was that this feature hasn't worked for years and no one really wants it.

njlxyaoxinwei commented 9 years ago

Overridden by #350