search

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Switch from `vestal_versions` to `paper_trail` #345

Closed shippy closed 9 years ago

shippy commented 10 years ago

Currently, vestal_versions raises ActiveRecord::DangerousAttributeError; it is also not maintained beyond Rails 3.2.16. We should switch to PaperTrail. We have the go-ahead to drop the current table versions in a migration, with the understanding that we'll back up whatever the current contents of versions are during deployment.

mnquintana commented 10 years ago

Okay so the change was successful on my branch 345_paper_trail, but we're going to have to do some serious, serious refactoring in these views - they are absolutely insane. They are so chock-full of logic I'm not even sure if the controller's doing anything. I mean, payforms/_payform_item.html.erb recursively renders itself if a payform item is versioned. Like, what?

shippy commented 10 years ago

I pull-requested @mnquintana's branch (#365) so that we can comment on the code directly.

shippy commented 9 years ago

Closed via #365.