YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Display version in the footer #346

Closed shippy closed 10 years ago

shippy commented 10 years ago

In the interest of transparency, Shifts should have the release number in the footer. This should be trivial to implement, taking Reservations#560 as example.

thomasweng15 commented 10 years ago

I read through the reservations issue log and noticed that you were deciding whether to use 'git describe' or 'git describe --tag'. In the reservations issue, 'git describe' produced ugly output, but on shifts, it seems to be the opposite situation:

$ git describe
v2.0.0-383g27de87d
$ git describe --tag
v3.0.0.alpha10-172-g27de87d

So for now I will proceed with using the former rather than the latter.

mnquintana commented 10 years ago

Hmm, I get identical output with both commands.

thomasweng15 commented 10 years ago

Did you get the former or the latter for both?

Since we are releasing version 3.0.0 I should actually probably use the latter. When I run git describe --tags --abbrev=0 I get v3.0.0.alpha10.