YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Can't delete zero-length shift #364

Open orenyk opened 10 years ago

orenyk commented 10 years ago

I accidentally submitted a shift several seconds after creating it, adding a zero-length shift to my payform. When trying to delete it, it triggered the error "Hours must be greater than 0", even though that validation wasn't triggered on creation (I'm guessing since you're not checking for minutes specifically, so if start and end time were different, even by a few seconds, it would save... just a guess). I'm assuming you don't actually destroy the record when it's deleted from a payform, based on the fact that you're asking for notes, so it's still running the model validations even though that item is going to be "deleted". Not sure what the best fix for this is since I don't know your code base, but thought I'd pass it along. Good luck!