Bootstrap Modal loading is slow, substitute default text for "Loading"

YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.

MIT License

23 stars 18 forks source link

Bootstrap Modal loading is slow, substitute default text for "Loading" #408

Closed shippy closed 10 years ago

shippy commented 10 years ago

Self-explanatory. @njlxyaoxinwei is on it.

njlxyaoxinwei commented 10 years ago

the current implementation is deprecated in newer bootstrap and will be removed in bootstrap v4! https://github.com/twbs/bootstrap/pull/14034 http://getbootstrap.com/javascript/#modals

njlxyaoxinwei commented 10 years ago

All the modal trigger links/buttons in the code-base:

three helper methods in application_helper.rb helper method in payforms_helper.rb views/data_objects/_report_data_object.html.erb views/data_objects/update_data_objects.html.erb views/notices/_announcement.html.erb two links in views/payforms/_payform_item.html.erb views/reports/tasks_and_objects_list.html.erb

njlxyaoxinwei commented 10 years ago

I will not bother with this for now. We can do jquery.load ourselves when the time comes.