YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Shifts not creating payforms every week automatically #441

Open njlxyaoxinwei opened 9 years ago

njlxyaoxinwei commented 9 years ago

Shifts does not create the payform for the week unless the user manually navigate to "My Current Payform" or sign out of a shift during that week (defined as the 7-day period between Sun and Sat). Having payform items when not having had any shifts is rare, but now it is not possible to add items to past payforms if it was not created, i.e. the user did not have any shifts during that week.

From the admin's point of view, having Shifts create payforms every week for every user will clutter the payform index view, and employees should not be able to create payforms of missed weeks too far into the past.

njlxyaoxinwei commented 9 years ago

After discussion with Jemin, we are going to allow the user to create payforms up to one-week back when creating the current payform. One only needs to modify the go method in payform controller to build two payforms, one for current week and another for last week.

Or alternatively, this can be a custom value in the DepartmentConfig.