YaleSTC / shifts

Application to easily track shifts, reports, and payforms for employees.
MIT License
23 stars 18 forks source link

Shift Merge Fails #482

Open stuartteal opened 8 years ago

stuartteal commented 8 years ago

If a user is logged into a shift and they create a new shift that begins at the same time as the next shift is to begin, shifts will merge the shifts.

Shifts does correctly merge the shifts in that there is only one, longer shift, at the end of the merger.

However, when the user attempts to return to their shift report, they cannot access it anymore. They are still signed into their shift and cannot sign out, cannot update, cannot return to their shift report, and cannot delete their shift. Ony an admin destroying the entire shift object gets the user signed out.

correct behavior would be to merge the shifts and allow the user to return to their shift report post merger and then be able to submit their shift report as usual.

AlanLiu96 commented 8 years ago

Hi Stuart I'm looking into shifts now to see if we can provide a band-aid fix for you guys since no one is actively working on shifts. I'm not sure how to "create a new shift that begins at the same time as the next shift is to begin." When I create a shift that starts earlier than my current shift, it tells me I can't create an earlier shift than the current time. When I try to create a shift that starts later, it tells me that I can't sign up for a shift that's not in a timeslot. I haven't ever used scheduled shifts before, but could you provide some details on what to do to extend a shift and break it? Thanks.