search

YaleUniversity / packer-plugin-goss

Goss Provisioner for Packer
MIT License
136 stars 45 forks source link

Need automated build for binaries #34

Closed fishnix closed 3 years ago

fishnix commented 4 years ago

Opening for comments, not looking for PRs at this time for this Issue.

I would like to setup a github action to automatically build and deploy this project on release. In other projects, I'm using wangyoucao577/go-release-action and would like to continue using the same action but it will result in compressed binaries that would need to be uncompressed after download.

Would this cause a problem for where you are using this provisioner?

fishnix commented 4 years ago

@EleanorRigby

EleanorRigby commented 4 years ago

@fishnix : Will this also apply to old binaries?

If this is just for new binaries from henceforth, I can add an extra step to unzip/untar and then place it in ~/.packer.d/plugins

EleanorRigby commented 4 years ago

Is it also possible for you to open maintenance and more admin role for this repo to folks outside YaleUniversity org?. I can help shoulder some release and review work if you are interested.

fishnix commented 4 years ago

Hi @EleanorRigby -

It would definitely not apply to old binaries, just new ones after the current release.

I don't know if it's possible to allow other folks into the repo honestly, but I can try to find out. I'm happy to have other eyes on any PRs that come through though if you're interested in doing some of that as well. Automating the build and upload of binaries will make the process quite a bit less tedious. 😄

Thanks for the input and PRs!

fishnix commented 3 years ago

Heads up @EleanorRigby - v2.0.0 will have compressed binary releases

EleanorRigby commented 3 years ago

@fishnix : I tried release 1.4.0, it seems the binaries are not packaged right. It gives exec error. Can you check?

fishnix commented 3 years ago

Did you try release v2.0.0 or v1.4.0 ? I didn't upload any binaries for v1.4.0... maybe that's the issue?

EleanorRigby commented 3 years ago

Now trying v2.0.0 , seems to work well. Thanks for your help.

On Thu, Sep 10, 2020, 10:26 AM E Camden Fisher notifications@github.com wrote:

Did you try release v2.0.0 or v1.4.0 ? I didn't upload any binaries for v1.4.0... maybe that's the issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YaleUniversity/packer-provisioner-goss/issues/34#issuecomment-690536251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRV6KRNCQ4Z43CZSOPPFULSFED37ANCNFSM4PXXZE4Q .

fishnix commented 3 years ago

glad to hear it! 👍