Add support to download goss spec form remote VM

[EleanorRigby]

This adds support for downloading goss-spec and debug goss-spec to /tmp folder on local machine.

This spec then can be added to images' release manifest or notes as a verification receipt.

==> amazon-2: Downloading spec file and debug info
    amazon-2: Downloading Goss specs from, /tmp/goss-spec.yaml and /tmp/debug-goss-spec.yaml to current dir

~/workspace/eleanor/packer-provisioner-goss(ta-AddVisibility) » ls -al /tmp/*goss*            taggarwal@taggarwal-a01
-rw-r--r--  1 taggarwal  wheel  4724 Aug 28 15:44 /tmp/debug-goss-spec.yaml
-rw-r--r--  1 taggarwal  wheel  2179 Aug 28 15:44 /tmp/goss-spec.yaml

[EleanorRigby]

@fishnix : please review.

cc: @codenrhoden

[fishnix]

This looks good.

Two questions:

• should we add something to the README?
• should we be able to turn the functionality on/off? (on by default is okay with me if thats what you're looking for)

Thanks!

[EleanorRigby]

Good point. I will make a commit for readme.

I think we don't need an option as these files are like log files and basically what spec Goss ran. I am outputting these in tmp folder so it should get cleaned up anyway if the user doesn't explicitly take them out from there and save.

What do you think?

On Tue, Sep 1, 2020, 4:02 AM E Camden Fisher notifications@github.com wrote:

This looks good.

Two questions:

• should we add something to the README?
• should we be able to turn the functionality on/off?

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/YaleUniversity/packer-provisioner-goss/pull/35#issuecomment-684770317, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRV6KW2KNHC5Y6SZC4K7ADSDTIEXANCNFSM4QOSZTFQ .

[fishnix]

I am outputting these in tmp folder so it should get cleaned up anyway if the user doesn't explicitly take them out from there and save.

Okay that makes sense to me. Thanks!

[EleanorRigby]

Done with all commits