search

YaleUniversity / packer-plugin-goss

Goss Provisioner for Packer
MIT License
136 stars 45 forks source link

Update targetOs to target_os to fix packer errors #46

Closed frightenedmonkey closed 3 years ago

frightenedmonkey commented 3 years ago

The targetOs version of the parameter wasn't usable by packer directly, and I received an error attempting to use the merged version of the changes to use the 1.7 packer release. Turns out that when I rebased onto the windows support, I failed to directly test & ended up failing with a recurrence of the problem reported in issue 40, and specifically, the newer problem reported here

The solution was the same as for the struct tags added in the 1.7 compatibility upgrade, which was to provide a mapstructure struct tag. Apologies for missing the new parameter when I rebased.

frightenedmonkey commented 3 years ago

I did test a build with these changes locally to make sure it all worked & it's 💯

Lirt commented 3 years ago

I can test to double check if you want.

frightenedmonkey commented 3 years ago

@Lirt Please! I'd like to make sure it solves the issue for everyone.

fishnix commented 3 years ago

I didn't test with that parameter. @Lirt once you have a chance to test it, i can merge. Thanks!

Lirt commented 3 years ago

When I try to build using the source fork+branch frightenedmonkey:fix-another-struct-tag I get build errors:

$ go build -v -o packer-provisioner-goss-ova
go: github.com/hashicorp/packer-plugin-sdk@v0.0.11 requires
    github.com/hashicorp/packer@v1.6.7-0.20210126105722-aef4ced967ec: invalid version: unknown revision aef4ced967ec

I tried to bump packer-plugin-sdk to all available versions but all of them fail. I tried to build the scaffolding project https://github.com/hashicorp/packer-plugin-scaffolding but it fails as well.

Shall we report it to packer slack or am I doing something wrong?

frightenedmonkey commented 3 years ago

@Lirt weird, I haven't had any build issues. For clarity, I'm building it locally & I also have a container image where I'm building that branch from source in a CI build—that CI build is going to re-resolve all dependencies and download them at build time.

I also went and looked, and I see that SHA in the packer repository https://github.com/hashicorp/packer/commit/aef4ced967ec

I'm not sure what else to troubleshoot at the moment.

Lirt commented 3 years ago

That will be my local issue. Sorry I will try as soon as I fix it.

Lirt commented 3 years ago

Ok I fixed my issue and the PR works well in my environment. Thank you.