YaleUniversity / packer-plugin-goss

Goss Provisioner for Packer
MIT License
136 stars 45 forks source link

Url ssl support, auth support and custom gossfile support #6

Closed vamegh closed 6 years ago

fishnix commented 6 years ago

Hi! Thanks for the PR! It looks good. I'll test it a bit and merge it in afterwards.

vamegh commented 6 years ago

Hi @fishnix please hold off Im trying to add some further stuff - testing and I cleaned it up some.

vamegh commented 6 years ago

Hi @fishnix I have now tested everything here - its all working, if your happy to merge it in I would be happy.

Stuff added:

Custom Gossfile suport (the --gossfile flag) tests now supports uploading directories (I just linked to your existing function and perma set ignore to be blank - I dont think this will ever be needed) Username and Password for auth to download goss from custom internal services. Ssl Cert Check (can disable cert checking if required - for custom internal services using self-signed certs)

I think that about covers everything - we have tested here locally and it seems to be working as expected.

vamegh commented 6 years ago

Im closing this - as this was quite messy