search

YaleUniversity / packer-plugin-goss

Goss Provisioner for Packer
MIT License
136 stars 45 forks source link

Ability to download goss cli from somewhere else rather than github.com #84

Closed sshrestha02 closed 4 months ago

sshrestha02 commented 4 months ago

I've got a use case where the baseUrl needs to be different in getDownloadUrl function, we use Artifactory remote repo as proxy in between github and our environment. Could it be parameterized instead of hardcoded to be downloaded from github.com?

https://github.com/YaleUniversity/packer-plugin-goss/blob/ac683306d9b7699f3f476c7e067bb576d3917721/provisioner/goss/packer-provisioner-goss.go#L465

From end-users perspective, you just pass an arg:

Example:


  provisioner "goss" {
    goss_file     = "goss.yaml"
    retry_timeout = "5s"
    sleep         = "2s"
    tests         = ["goss.yaml"]
    goss_cli    = "https://prod.artifactory.com/artifactory"
  }
sshrestha02 commented 4 months ago

was going through the source code, I'll try setting the URL.

sshrestha02 commented 4 months ago

closing issue, setting url helped :)