search

YaleUniversity / packer-plugin-goss

Goss Provisioner for Packer
MIT License
136 stars 45 forks source link

amd64 for linux missing on the release #85

Closed dragon040 closed 3 months ago

dragon040 commented 4 months ago

Some how I am not able to see the release "packer-plugin-goss_v3.2.9_x5.0_linux_amd64.zip" on the list.

FalcoSuessgott commented 4 months ago

Yeah linux_amd64 is excluded in goreleaser, as recommended in hashicorps scaffolding template (https://github.com/hashicorp/packer-plugin-scaffolding/blob/bf869f2cc3ebfd3b520ddad5fb63f66144810fe0/.goreleaser.yml#L53). I cant really tell you how but it should nevertheless work for linux_amd64 systems as I have used it successfully locally and during CI.. did u give it a try?

alfredkrohmer commented 4 months ago

Yeah linux_amd64 is excluded in goreleaser, as recommended in hashicorps scaffolding template (https://github.com/hashicorp/packer-plugin-scaffolding/blob/bf869f2cc3ebfd3b520ddad5fb63f66144810fe0/.goreleaser.yml#L53)

The line you are referring to is already 4 years old, however, for this plugin, this was only added in the last release. Are you sure that this is a recommendation and not just an example?

I cant really tell you how but it should nevertheless work for linux_amd64 systems as I have used it successfully locally and during CI.. did u give it a try?

We have used it for several years now on linux_amd64 (locally and CI) and I would even bet that this is the main platform where this is used on. Please add it back.

FalcoSuessgott commented 4 months ago

I will reproduce and open a PR in the next days as soon as i have stable internet again

FalcoSuessgott commented 4 months ago

until #86 is merged u should be able to use v3.2.8