search

Yalies / api

👥 The best directory of Yale personnel, with a clean API to match. Used by 70% of undergrads!
https://yalies.io
12 stars 23 forks source link

Change student photo from background-image to an actual image element #241

Open ericyoondotcom opened 8 months ago

ericyoondotcom commented 8 months ago

Right now, student ID photos are displayed with the background-image property instead of an img tag. This is bad for accessibility, and also it means you can't right click to save the image.

ErikBoesen commented 8 months ago

I see the accessibility argument (although to my understanding, alt text is not considered necessary for compliance with accessibility policies if the image in question is right next to a text label of what it represents), but I recall the lack of right-click support being intentional. I think I was concerned that individuals may be bothered if it's especially easy to download their photos. But it really doesn't change anything practically speaking so I am ambivalent about this.

ErikBoesen commented 8 months ago

I think there was some other reason I wanted to use background image instead. But I don't remember what it was anymore.