Yalies / api

👥 The best directory of Yale personnel, with a clean API to match. Used by 70% of undergrads!
https://yalies.io
12 stars 23 forks source link

Privacy features && social handles #242

Closed ericyoondotcom closed 7 months ago

ericyoondotcom commented 8 months ago

Description

Fixes #232 Fixes #206 Fixes #231

This PR adds the ability to hide information from the Yalies.io website, using a new profile editor page. Also, you can add your Instagram/Snapchat handle which will be displayed when someone searches you up.

Screenshot 2024-03-18 at 5 56 19 PM Screenshot 2024-03-18 at 5 56 37 PM

TODO

This code reduces performance of people queries. Since the persistent data is stored in another table, for each person result, the secondary table has to be queried. There might be a way to optimize this.

You can't see the performance impact on the yalies website because pagination keeps it to a limited number of people per query, but if you use the API to query all people in the directory, it takes significantly longer than before.

Checklist

ericyoondotcom commented 8 months ago

Request from Katherine to remove Snapchat feature bc of sus connotations. Just Instagram for now

ericyoondotcom commented 7 months ago

Superseded by #264