search

Yalies / api

👥 The best directory of Yale personnel, with a clean API to match. Used by 70% of undergrads!
https://yalies.io
12 stars 23 forks source link

Room/floor information missing #277

Open ericyoondotcom opened 1 week ago

ericyoondotcom commented 1 week ago

We got a student email asking why "room" information was not available / not able to be filtered by.

I did a quick manual check on some data, and it looks like no room, floor, entryway, or suite information is being returned by the Yalies API.

@ErikBoesen — was it always like this? Is this an intentional choice for privacy? If so, we should change the API docs to not say

Most properties can be filtered by, including [...] room

If this was not an intentional change, it may have been caused by a change in the Yale Face Book. Doing a quick look at the Face Book, it appears that room numbers are not appearing on the website. The code seems to indicate that the aforementioned properties are scraped from the Face Book.

ErikBoesen commented 1 week ago

Yeah, this is because the Face Book used to have room numbers and have since removed them. Honestly we can probably just remove these fields completely