Yalir / sfeMovie

sfeMovie is a simple C++ library that lets you play movies in SFML based applications. It relies on FFmpeg to read medias and remains consistent with SFML's naming conventions.
http://sfemovie.yalir.org/
GNU Lesser General Public License v2.1
114 stars 37 forks source link

Dropping dependencies in project #18

Closed nicholaskell closed 12 years ago

nicholaskell commented 12 years ago

How do you feel about dropping all the depends sources from your project and rely on the user to have the deps installed?

Reason why I mention it is that I had ffmpeg installed and the first time I compiled and installed sfeMovie it recompiled and installed over my current ffmpeg install.

To the best of my knowledge, the libraries that I download and install do not include all the dependent libraries.

I am currently evaluating SFML and sfeMovie for use in a kiosk type system running on a custom version of Linux. So for me to implement it easily (on many systems), I forked your code and did what I suggested here: https://github.com/nicholaskell/sfeMovie

Ceylo commented 12 years ago

Hello nicholaskell,

I'm sorry I didn't see your post earlier (and I didn't get any notification whatsoever). I do not want to remove the dependencies because :

Although I admit the last point is not that much true on Linux, because the user will have to manually install the SFML dependencies. Is it possible to check how the FFmpeg package from the apt repository was built ?

In any case, I will not drop these dependencies because there's no such system as APT (by default) on Windows and Mac OS X. But I should mention that a Linux user has encountered the same issue as you, and improved the CMakeLists.txt file so that the user can choose between using the provided FFmpeg sources and the already installed FFmpeg libraries. I realize this is useless if you follow the wiki instructions though, as the build.sh script does not make use of this improvement. I guess I'll fix this when I redo the build process (make CMake the main controller of the build process, instead of the build.sh script).