Yalir / sfeMovie

sfeMovie is a simple C++ library that lets you play movies in SFML based applications. It relies on FFmpeg to read medias and remains consistent with SFML's naming conventions.
http://sfemovie.yalir.org/
GNU Lesser General Public License v2.1
114 stars 37 forks source link

Build FFMPEG In CMake Build Directory (not source) #29

Closed firefly2442 closed 11 years ago

firefly2442 commented 11 years ago

In the CMake-Directed branch, it looks like FFMPEG is being built inside the source directory. It would be nice if it would build this in the build directory that CMake uses. This way the source directory doesn't get all cluttered.

Edited by Ceylo: AC:

Ceylo commented 11 years ago

Not much to say but just a comment so that you know I agree with you and that it'll be done

firefly2442 commented 11 years ago

What do you think about passing the Cmake source and build directories specified by the user to the BASH build script? Then, copying the sourcecode to the build directory and doing the build of FFmpeg there?

Ceylo commented 11 years ago

Actually, we wouldn't even need to copy FFmpeg sources: http://stackoverflow.com/questions/7154402/autoconf-build-directory

But yes using the same build dir for both FFmpeg and CMake seems like a good idea.

Ceylo commented 11 years ago

As for copying FFmpeg sources, they are now extracted from the archive to /tmp because if they're extracted in a directory whose path contains spaces, configuration fails (it explicitly states that it can't work in this case).